lkml.org 
[lkml]   [2017]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 16/95] mm, memcg: fix mem_cgroup_swapout() for THPs
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Shakeel Butt <shakeelb@google.com>

    commit d08afa149acfd00871484ada6dabc3880524cd1c upstream.

    Commit d6810d730022 ("memcg, THP, swap: make mem_cgroup_swapout()
    support THP") changed mem_cgroup_swapout() to support transparent huge
    page (THP).

    However the patch missed one location which should be changed for
    correctly handling THPs. The resulting bug will cause the memory
    cgroups whose THPs were swapped out to become zombies on deletion.

    Link: http://lkml.kernel.org/r/20171128161941.20931-1-shakeelb@google.com
    Fixes: d6810d730022 ("memcg, THP, swap: make mem_cgroup_swapout() support THP")
    Signed-off-by: Shakeel Butt <shakeelb@google.com>
    Acked-by: Johannes Weiner <hannes@cmpxchg.org>
    Acked-by: Michal Hocko <mhocko@suse.com>
    Cc: Huang Ying <ying.huang@intel.com>
    Cc: Vladimir Davydov <vdavydov.dev@gmail.com>
    Cc: Greg Thelen <gthelen@google.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

    ---
    mm/memcontrol.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/mm/memcontrol.c
    +++ b/mm/memcontrol.c
    @@ -6044,7 +6044,7 @@ void mem_cgroup_swapout(struct page *pag
    memcg_check_events(memcg, page);

    if (!mem_cgroup_is_root(memcg))
    - css_put(&memcg->css);
    + css_put_many(&memcg->css, nr_entries);
    }

    /**

    \
     
     \ /
      Last update: 2017-12-04 17:28    [W:3.202 / U:0.548 seconds]
    ©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site