[lkml]   [2017]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] drm/i915: Mark expected switch fall-throughs
Hi Joonas,

Quoting Joonas Lahtinen <>:

> On Mon, 2017-11-27 at 16:17 -0600, Gustavo A. R. Silva wrote:
>> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
>> where we are expecting to fall through.
> I have to say I'm totally not sold on regexps matching comment
> contents. Was something more explicit ever considered? Like:
> #define FALLTHROUGH __attribute__((fallthrough));
> With the appropriate version checks, of course.

One of the arguments is that comments lets us leverage the existing
static analyzers.

We've been discussing this during the last week, feel free to join the

Gustavo A. R. Silva

 \ /
  Last update: 2017-12-04 16:22    [W:0.060 / U:4.668 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site