Messages in this thread | | | Date | Mon, 4 Dec 2017 15:00:12 +0100 | From | Greg Kroah-Hartman <> | Subject | Re: [GIT PULL] hash addresses printed with %p |
| |
On Mon, Dec 04, 2017 at 12:51:13PM +0000, David Laight wrote: > From: Ard Biesheuvel > > Sent: 04 December 2017 10:03 > ... > > and uses __ATTR_RO() to emit initializers for it. __ATTR() initializes > > the .store member as well, which does not exists, and so it cannot be > > used directly. > > > > So we should either add a .store member that is always NULL, or we > > should add our own > > > > #define __ATTR_0400(_name) { \ > > .attr = { .name = __stringify(_name), .mode = 0400 }, \ > > .show = _name##_show, \ > > } > > What about an __ATTR_RO_MODE(name, mode) that doesn't set the .store member. > Even if the mode allowed write, writes wouldn't happen.
Ah, that might work, could you convert the other users of __ATTR() in the efi code to use it as well?
thanks,
greg k-h
| |