Messages in this thread | | | Date | Mon, 4 Dec 2017 12:32:02 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH] Staging: pi433: fix brace coding style issues in pi433_if.c |
| |
On Sat, Dec 02, 2017 at 10:05:20PM +0100, Tomas Marek wrote: > @@ -578,13 +546,9 @@ static irqreturn_t DIO1_irq_handler(int irq, void *dev_id) > SET_CHECKED(rf69_set_mode(spi, standby)); /* this clears the fifo */ > SET_CHECKED(rf69_set_fifo_threshold(spi, FIFO_THRESHOLD)); > if (tx_cfg.enable_length_byte == optionOn) > - { > SET_CHECKED(rf69_set_payload_length(spi, size * tx_cfg.repetitions)); > - } > else > - { > SET_CHECKED(rf69_set_payload_length(spi, 0)); > - } >
You can't delete the curly braces here because SET_CHECKED() is utter garbage. SET_CHECKED() needs to be wrapped in a do-while(0) loop. But someone sent a patch to delete it entirely which is even better.
regards, dan carpenter
| |