[lkml]   [2017]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] netfilter: nfnetlink_cthelper: Add missing permission checks
On Sun, Dec 03, 2017 at 12:12:45PM -0800, Kevin Cernekee wrote:
> The capability check in nfnetlink_rcv() verifies that the caller
> has CAP_NET_ADMIN in the namespace that "owns" the netlink socket.
> However, nfnl_cthelper_list is shared by all net namespaces on the
> system.

Right, we need per-netns support for nfnetlink_cthelper.

> An unprivileged user can create user and net namespaces
> in which he holds CAP_NET_ADMIN to bypass the netlink_net_capable()
> check:

Applied to nf, thanks.
> I think xt_osf has the same issue with respect to xt_osf_fingers.
> Also, it looks like nlmon devices created in an unprivileged netns can
> see netlink activity from the init namespace.

A fix that one would be good too.

 \ /
  Last update: 2017-12-04 11:32    [W:0.029 / U:1.068 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site