lkml.org 
[lkml]   [2017]   [Dec]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] sky2: Replace mdelay with msleep in sky2_vpd_wait
On Sat, 30 Dec 2017 19:09:47 +0800
Jia-Ju Bai <baijiaju1990@gmail.com> wrote:

> sky2_vpd_wait is not called in an interrupt handler nor holding a spinlock.
> The function mdelay in it can be replaced with msleep, to reduce busy wait.
>
> Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
> ---
> drivers/net/ethernet/marvell/sky2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/marvell/sky2.c b/drivers/net/ethernet/marvell/sky2.c
> index 9efe177..9fe8530 100644
> --- a/drivers/net/ethernet/marvell/sky2.c
> +++ b/drivers/net/ethernet/marvell/sky2.c
> @@ -4287,7 +4287,7 @@ static int sky2_vpd_wait(const struct sky2_hw *hw, int cap, u16 busy)
> dev_err(&hw->pdev->dev, "VPD cycle timed out\n");
> return -ETIMEDOUT;
> }
> - mdelay(1);
> + msleep(1);
> }
>
> return 0;

When sky2 was written mdelay was equivalent to current msleep.

Acked-by: Stephen Hemminger <stephen@networkplumber.org>

\
 
 \ /
  Last update: 2017-12-30 18:20    [W:0.049 / U:2.276 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site