lkml.org 
[lkml]   [2017]   [Dec]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [alsa-devel] [PATCH v4 00/15] soundwire: Add a new SoundWire subsystem
    On Fri, Dec 01, 2017 at 06:24:10PM -0600, Pierre-Louis Bossart wrote:
    > On 12/1/17 3:56 AM, Vinod Koul wrote:
    > >This patch series adds a new SoundWire subsystem which implements a
    > >new MIPI bus protocol 'SoundWire'.
    >
    > Sorry for the late feedback Vinod and team.
    >
    > Overall the code looks very good to me and aligned with the MIPI specs,
    > there are only a couple of points that were added (or some code not removed)
    > during the code cleanups, e.g.
    > - device12..14 should not be used
    > - device_property handling (master/controller confusion?)
    > - error cases on transfers
    > - spec race condition on interrupt clear (not bad but to be discussed
    > further)
    > - some comments and code nit-picks
    >
    > This is starting to get into second-order reviews really, which shows this
    > is becoming quite mature. And for the record this work isn't just scratching
    > the surface, it helped identify a couple of documentation issues in the MIPI
    > specs which will lead to clarifications in future revisions.

    Thanks for the good word, most the stuff you pointed needs a very detailed
    review, so many thaks for spending time on this one.

    > Looking forward to a v5 ;-)

    Yeah should be there in next few days..

    --
    ~Vinod

    \
     
     \ /
      Last update: 2017-12-03 18:10    [W:3.049 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site