lkml.org 
[lkml]   [2017]   [Dec]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] Coccinelle: array_size: report even if include is missing
Hi,

On Thu, 14 Sep 2017 13:21:13 +0200 (CEST)
Julia Lawall <julia.lawall@lip6.fr> wrote:

> On Wed, 13 Sep 2017, Jérémy Lefaure wrote:
>
> > Rule r does not depend on rule i (which is the include of
> > linux/kernel.h) so the output should not depend on i in
> > org and report mode.
> >
> > Signed-off-by: Jérémy Lefaure <jeremy.lefaure@lse.epita.fr>
>
> Acked-by: Julia Lawall <julia.lawall@lip6.fr>
>
> I guess that if the incude is missing, the person updating the code can
> always add it.
>
I don't see this patch upstream, is it lost somewhere or should I send
it to someone else ?


>
> > ---
> >
> > I have tested this patch in report mode on the file
> > drivers/staging/rtlwifi/phydm/rtl8822b/halhwimg8822b_rf.c which does not
> > use ARRAY_SIZE and does not include linux/kernel.h.
> >
> > scripts/coccinelle/misc/array_size.cocci | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/scripts/coccinelle/misc/array_size.cocci b/scripts/coccinelle/misc/array_size.cocci
> > index 6ec05710b017..09520f0941f0 100644
> > --- a/scripts/coccinelle/misc/array_size.cocci
> > +++ b/scripts/coccinelle/misc/array_size.cocci
> > @@ -72,13 +72,13 @@ position p;
> > (sizeof(E)@p /sizeof(T))
> > )
> >
> > -@script:python depends on i&&org@
> > +@script:python depends on org@
> > p << r.p;
> > @@
> >
> > coccilib.org.print_todo(p[0], "WARNING should use ARRAY_SIZE")
> >
> > -@script:python depends on i&&report@
> > +@script:python depends on report@
> > p << r.p;
> > @@
> >
> > --
> > 2.14.1
> >
> >

\
 
 \ /
  Last update: 2017-12-29 18:28    [W:0.032 / U:9.144 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site