Messages in this thread | | | Date | Fri, 29 Dec 2017 13:49:55 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH 3/3] perf/core: Move inline keyword at the beginning of declaration |
| |
* Mathieu Malaterre <malat@debian.org> wrote:
> Hi Ingo, > > On Thu, Dec 28, 2017 at 1:15 PM, Ingo Molnar <mingo@kernel.org> wrote: > > > > * Mathieu Malaterre <malat@debian.org> wrote: > > > >> Fix non-fatal warnings such as: > >> > >> kernel/events/ring_buffer.c:116:1: warning: ‘inline’ is not at beginning of declaration [-Wold-style-declaration] > >> static int __always_inline > >> ^~~~~~ > >> > >> Signed-off-by: Mathieu Malaterre <malat@debian.org> > >> --- > >> kernel/events/ring_buffer.c | 6 +++--- > >> 1 file changed, 3 insertions(+), 3 deletions(-) > > > > Hm, never saw this warning before - is this a newly default GCC warning, or some > > distro CFLAGS build that enables it? > > Nope. Just compiling vanilla kernel with default options, defconfig > was pmac32. I used W=1.
"W=1" is not a default build variant - it enables -Wall...
This absolutely needs to be spelled out in the changelog!
Thanks,
Ingo
| |