Messages in this thread | | | Subject | Re: [PATCH][next] wcn36xx: remove redundant assignment to msg_body.min_ch_time | From | Colin Ian King <> | Date | Fri, 29 Dec 2017 10:52:41 +0000 |
| |
On 29/12/17 07:44, Loic Poulain wrote: > Hi Colin, Bjorn, > > On 26 December 2017 at 21:13, Bjorn Andersson > <bjorn.andersson@linaro.org> wrote: >> On Tue 19 Dec 09:04 PST 2017, Colin King wrote: >> >>> From: Colin Ian King <colin.king@canonical.com> >>> >>> msg_body.min_ch_time is being assigned twice; remove the redundant >>> first assignment. >>> >>> Detected by CoverityScan, CID#1463042 ("Unused Value") >>> >> >> Happy to see Coverity working for us :) >> >> >> This should have had a: >> >> Fixes: 2f3bef4b247e ("wcn36xx: Add hardware scan offload support") >> >>> Signed-off-by: Colin Ian King <colin.king@canonical.com> >>> --- >>> drivers/net/wireless/ath/wcn36xx/smd.c | 1 - >>> 1 file changed, 1 deletion(-) >>> >>> diff --git a/drivers/net/wireless/ath/wcn36xx/smd.c b/drivers/net/wireless/ath/wcn36xx/smd.c >>> index 2914618a0335..bab2eca5fcac 100644 >>> --- a/drivers/net/wireless/ath/wcn36xx/smd.c >>> +++ b/drivers/net/wireless/ath/wcn36xx/smd.c >>> @@ -625,7 +625,6 @@ int wcn36xx_smd_start_hw_scan(struct wcn36xx *wcn, struct ieee80211_vif *vif, >>> INIT_HAL_MSG(msg_body, WCN36XX_HAL_START_SCAN_OFFLOAD_REQ); >>> >>> msg_body.scan_type = WCN36XX_HAL_SCAN_TYPE_ACTIVE; >>> - msg_body.min_ch_time = 30; >>> msg_body.min_ch_time = 100; >> >> But I strongly suspect the second line is supposed to be max_ch_time. >> >> @Loic, do you agree? > > You're absolutely right. > Colin could you please update your patch accordingly?
Resent as "wcn36xx: fix incorrect assignment to msg_body.min_ch_time"
> > Regards, > Loic > -- > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >
| |