lkml.org 
[lkml]   [2017]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 013/204] xhci: fix finding correct bus_state structure for USB 3.1 hosts
    3.16.52-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Mathias Nyman <mathias.nyman@linux.intel.com>

    commit 5a838a13c9b4e5dd188b7a6eaeb894e9358ead0c upstream.

    xhci driver keeps a bus_state structure for each hcd (usb2 and usb3)

    The structure is picked based on hcd speed, but driver only compared
    for HCD_USB3 speed, returning the wrong bus_state for HCD_USB31 hosts.

    This caused null pointer dereference errors in bus_resume function.

    Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/usb/host/xhci.h | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/usb/host/xhci.h
    +++ b/drivers/usb/host/xhci.h
    @@ -1437,7 +1437,7 @@ struct xhci_bus_state {

    static inline unsigned int hcd_index(struct usb_hcd *hcd)
    {
    - if (hcd->speed == HCD_USB3)
    + if (hcd->speed >= HCD_USB3)
    return 0;
    else
    return 1;
    \
     
     \ /
      Last update: 2017-12-28 19:06    [W:2.250 / U:0.408 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site