lkml.org 
[lkml]   [2017]   [Dec]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v6 1/8] arch: enable relative relocations for arm64, power, x86, s390 and x86
    On Wed, Dec 27, 2017 at 12:50 AM, Ard Biesheuvel
    <ard.biesheuvel@linaro.org> wrote:
    > diff --git a/arch/arm64/kernel/vmlinux.lds.S b/arch/arm64/kernel/vmlinux.lds.S
    > index 7da3e5c366a0..49ae5b43fe2b 100644
    > --- a/arch/arm64/kernel/vmlinux.lds.S
    > +++ b/arch/arm64/kernel/vmlinux.lds.S
    > @@ -156,7 +156,7 @@ SECTIONS
    > CON_INITCALL
    > SECURITY_INITCALL
    > INIT_RAM_FS
    > - *(.init.rodata.* .init.bss) /* from the EFI stub */
    > + *(.init.rodata.* .init.bss .init.discard.*) /* EFI stub */
    > }
    > .exit.data : {
    > ARM_EXIT_KEEP(EXIT_DATA)

    Weren't you supposed to explain this part in the commit message?

    It isn't obvious why this is mixed up with the Kconfig changes, and
    somebody already asked about it. The commit message only talks about
    the Kconfig changes, and then suddenly there's that odd vmlinux.lds.S
    change in there...

    Linus

    \
     
     \ /
      Last update: 2017-12-27 20:56    [W:6.538 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site