Messages in this thread | | | From | Bjorn Andersson <> | Date | Tue, 26 Dec 2017 13:26:04 -0800 | Subject | Re: [RESEND][PATCH 1/4] of: platform: populate /firmware/ node from of_platform_default_populate_init() |
| |
On Thu, Sep 28, 2017 at 3:45 AM, Sudeep Holla <sudeep.holla@arm.com> wrote: > Since "/firmware" does not have its own "compatible" property as it's > just collection of nodes representing firmware interface, it's sub-nodes > are not populated during system initialization. > > Currently different firmware drivers search the /firmware/ node and > populate the sub-node devices selectively. Instead we can populate > the /firmware/ node during init to avoid more drivers continuing to > populate the devices selectively. > > To generalize the solution this patch populates the /firmware/ node > explicitly from of_platform_default_populate_init(). > > Cc: Arnd Bergmann <arnd@arndb.de> > Cc: Rob Herring <robh@kernel.org>
Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org> Tested-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> > ---
Andy, as you picked patch 2/4 into your v4.16 -next branch we no longer probe the qcom_scm device, causing various breakage. Can you please pick this patch as well (it has Rob's ack).
Regards, Bjorn
> drivers/of/platform.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/of/platform.c b/drivers/of/platform.c > index ac15d0e3d27d..3a213a6aee89 100644 > --- a/drivers/of/platform.c > +++ b/drivers/of/platform.c > @@ -515,6 +515,10 @@ static int __init of_platform_default_populate_init(void) > of_platform_device_create(node, NULL, NULL); > } > > + node = of_find_node_by_path("/firmware"); > + if (node) > + of_platform_populate(node, NULL, NULL, NULL); > + > /* Populate everything else. */ > of_platform_default_populate(NULL, NULL, NULL); > > -- > 2.7.4 >
| |