Messages in this thread | | | Date | Sat, 23 Dec 2017 14:48:31 +0100 | From | Greg KH <> | Subject | Re: [PATCH v3 00/27] kill devm_ioremap_nocache |
| |
On Sat, Dec 23, 2017 at 06:55:25PM +0800, Yisheng Xie wrote: > Hi all, > > When I tried to use devm_ioremap function and review related code, I found > devm_ioremap and devm_ioremap_nocache is almost the same with each other, > except one use ioremap while the other use ioremap_nocache.
For all arches? Really? Look at MIPS, and x86, they have different functions.
> While ioremap's > default function is ioremap_nocache, so devm_ioremap_nocache also have the > same function with devm_ioremap, which can just be killed to reduce the size > of devres.o(from 20304 bytes to 18992 bytes in my compile environment). > > I have posted two versions, which use macro instead of function for > devm_ioremap_nocache[1] or devm_ioremap[2]. And Greg suggest me to kill > devm_ioremap_nocache for no need to keep a macro around for the duplicate > thing. So here comes v3 and please help to review.
I don't think this can be done, what am I missing? These functions are not identical, sorry for missing that before.
thanks,
greg k-h
| |