Messages in this thread | | | Date | Fri, 22 Dec 2017 13:03:52 -0800 | From | Jakub Kicinski <> | Subject | Re: [PATCH v2 bpf-next 1/2] tools/bpftool: use version from the kernel source tree |
| |
On Fri, 22 Dec 2017 16:11:51 +0000, Roman Gushchin wrote: > Bpftool determines it's own version based on the kernel > version, which is picked from the linux/version.h header. > > It's strange to use the version of the installed kernel > headers, and makes much more sense to use the version > of the actual source tree, where bpftool sources are. > > Fix this by building kernelversion target and use > the resulting string as bpftool version. > > Example: > before: > > $ bpftool version > bpftool v4.14.6 > > after: > $ bpftool version > bpftool v4.15.0-rc3 > > $bpftool version --json > {"version":"4.15.0-rc3"} > > Signed-off-by: Roman Gushchin <guro@fb.com> > Cc: Jakub Kicinski <jakub.kicinski@netronome.com> > Cc: Alexei Starovoitov <ast@kernel.org> > Cc: Daniel Borkmann <daniel@iogearbox.net>
Reviewed-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Thanks Roman!
| |