lkml.org 
[lkml]   [2017]   [Dec]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 73/78] thermal: hisilicon: Handle return value of clk_prepare_enable
    Date
    4.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Arvind Yadav <arvind.yadav.cs@gmail.com>

    commit 919054fdfc8adf58c5512fe9872eb53ea0f5525d upstream.

    clk_prepare_enable() can fail here and we must check its return value.

    Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
    Signed-off-by: Eduardo Valentin <edubezval@gmail.com>
    Signed-off-by: Kevin Wangtao <kevin.wangtao@hisilicon.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/thermal/hisi_thermal.c | 5 ++++-
    1 file changed, 4 insertions(+), 1 deletion(-)

    --- a/drivers/thermal/hisi_thermal.c
    +++ b/drivers/thermal/hisi_thermal.c
    @@ -389,8 +389,11 @@ static int hisi_thermal_suspend(struct d
    static int hisi_thermal_resume(struct device *dev)
    {
    struct hisi_thermal_data *data = dev_get_drvdata(dev);
    + int ret;

    - clk_prepare_enable(data->clk);
    + ret = clk_prepare_enable(data->clk);
    + if (ret)
    + return ret;

    data->irq_enabled = true;
    hisi_thermal_enable_bind_irq_sensor(data);

    \
     
     \ /
      Last update: 2017-12-22 11:34    [W:4.190 / U:0.216 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site