lkml.org 
[lkml]   [2017]   [Dec]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 74/78] MIPS: math-emu: Fix final emulation phase for certain instructions
    Date
    4.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Aleksandar Markovic <aleksandar.markovic@mips.com>

    commit 409fcace9963c1e8d2cb0f7ac62e8b34d47ef979 upstream.

    Fix final phase of <CLASS|MADDF|MSUBF|MAX|MIN|MAXA|MINA>.<D|S>
    emulation. Provide proper generation of SIGFPE signal and updating
    debugfs FP exception stats in cases of any exception flags set in
    preceding phases of emulation.

    CLASS.<D|S> instruction may generate "Unimplemented Operation" FP
    exception. <MADDF|MSUBF>.<D|S> instructions may generate "Inexact",
    "Unimplemented Operation", "Invalid Operation", "Overflow", and
    "Underflow" FP exceptions. <MAX|MIN|MAXA|MINA>.<D|S> instructions
    can generate "Unimplemented Operation" and "Invalid Operation" FP
    exceptions.

    The proper final processing of the cases when any FP exception
    flag is set is achieved by replacing "break" statement with "goto
    copcsr" statement. With such solution, this patch brings the final
    phase of emulation of the above instructions consistent with the
    one corresponding to the previously implemented emulation of other
    related FPU instructions (ADD, SUB, etc.).

    Fixes: 38db37ba069f ("MIPS: math-emu: Add support for the MIPS R6 CLASS FPU instruction")
    Fixes: e24c3bec3e8e ("MIPS: math-emu: Add support for the MIPS R6 MADDF FPU instruction")
    Fixes: 83d43305a1df ("MIPS: math-emu: Add support for the MIPS R6 MSUBF FPU instruction")
    Fixes: a79f5f9ba508 ("MIPS: math-emu: Add support for the MIPS R6 MAX{, A} FPU instruction")
    Fixes: 4e9561b20e2f ("MIPS: math-emu: Add support for the MIPS R6 MIN{, A} FPU instruction")
    Signed-off-by: Aleksandar Markovic <aleksandar.markovic@mips.com>
    Cc: Ralf Baechle <ralf@linux-mips.org>
    Cc: Douglas Leung <douglas.leung@mips.com>
    Cc: Goran Ferenc <goran.ferenc@mips.com>
    Cc: "Maciej W. Rozycki" <macro@imgtec.com>
    Cc: Miodrag Dinic <miodrag.dinic@mips.com>
    Cc: Paul Burton <paul.burton@mips.com>
    Cc: Petar Jovanovic <petar.jovanovic@mips.com>
    Cc: Raghu Gandham <raghu.gandham@mips.com>
    Cc: linux-mips@linux-mips.org
    Patchwork: https://patchwork.linux-mips.org/patch/17581/
    Signed-off-by: James Hogan <jhogan@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    arch/mips/math-emu/cp1emu.c | 28 ++++++++++++++--------------
    1 file changed, 14 insertions(+), 14 deletions(-)

    --- a/arch/mips/math-emu/cp1emu.c
    +++ b/arch/mips/math-emu/cp1emu.c
    @@ -1777,7 +1777,7 @@ static int fpu_emu(struct pt_regs *xcp,
    SPFROMREG(fs, MIPSInst_FS(ir));
    SPFROMREG(fd, MIPSInst_FD(ir));
    rv.s = ieee754sp_maddf(fd, fs, ft);
    - break;
    + goto copcsr;
    }

    case fmsubf_op: {
    @@ -1790,7 +1790,7 @@ static int fpu_emu(struct pt_regs *xcp,
    SPFROMREG(fs, MIPSInst_FS(ir));
    SPFROMREG(fd, MIPSInst_FD(ir));
    rv.s = ieee754sp_msubf(fd, fs, ft);
    - break;
    + goto copcsr;
    }

    case frint_op: {
    @@ -1814,7 +1814,7 @@ static int fpu_emu(struct pt_regs *xcp,
    SPFROMREG(fs, MIPSInst_FS(ir));
    rv.w = ieee754sp_2008class(fs);
    rfmt = w_fmt;
    - break;
    + goto copcsr;
    }

    case fmin_op: {
    @@ -1826,7 +1826,7 @@ static int fpu_emu(struct pt_regs *xcp,
    SPFROMREG(ft, MIPSInst_FT(ir));
    SPFROMREG(fs, MIPSInst_FS(ir));
    rv.s = ieee754sp_fmin(fs, ft);
    - break;
    + goto copcsr;
    }

    case fmina_op: {
    @@ -1838,7 +1838,7 @@ static int fpu_emu(struct pt_regs *xcp,
    SPFROMREG(ft, MIPSInst_FT(ir));
    SPFROMREG(fs, MIPSInst_FS(ir));
    rv.s = ieee754sp_fmina(fs, ft);
    - break;
    + goto copcsr;
    }

    case fmax_op: {
    @@ -1850,7 +1850,7 @@ static int fpu_emu(struct pt_regs *xcp,
    SPFROMREG(ft, MIPSInst_FT(ir));
    SPFROMREG(fs, MIPSInst_FS(ir));
    rv.s = ieee754sp_fmax(fs, ft);
    - break;
    + goto copcsr;
    }

    case fmaxa_op: {
    @@ -1862,7 +1862,7 @@ static int fpu_emu(struct pt_regs *xcp,
    SPFROMREG(ft, MIPSInst_FT(ir));
    SPFROMREG(fs, MIPSInst_FS(ir));
    rv.s = ieee754sp_fmaxa(fs, ft);
    - break;
    + goto copcsr;
    }

    case fabs_op:
    @@ -2095,7 +2095,7 @@ copcsr:
    DPFROMREG(fs, MIPSInst_FS(ir));
    DPFROMREG(fd, MIPSInst_FD(ir));
    rv.d = ieee754dp_maddf(fd, fs, ft);
    - break;
    + goto copcsr;
    }

    case fmsubf_op: {
    @@ -2108,7 +2108,7 @@ copcsr:
    DPFROMREG(fs, MIPSInst_FS(ir));
    DPFROMREG(fd, MIPSInst_FD(ir));
    rv.d = ieee754dp_msubf(fd, fs, ft);
    - break;
    + goto copcsr;
    }

    case frint_op: {
    @@ -2132,7 +2132,7 @@ copcsr:
    DPFROMREG(fs, MIPSInst_FS(ir));
    rv.w = ieee754dp_2008class(fs);
    rfmt = w_fmt;
    - break;
    + goto copcsr;
    }

    case fmin_op: {
    @@ -2144,7 +2144,7 @@ copcsr:
    DPFROMREG(ft, MIPSInst_FT(ir));
    DPFROMREG(fs, MIPSInst_FS(ir));
    rv.d = ieee754dp_fmin(fs, ft);
    - break;
    + goto copcsr;
    }

    case fmina_op: {
    @@ -2156,7 +2156,7 @@ copcsr:
    DPFROMREG(ft, MIPSInst_FT(ir));
    DPFROMREG(fs, MIPSInst_FS(ir));
    rv.d = ieee754dp_fmina(fs, ft);
    - break;
    + goto copcsr;
    }

    case fmax_op: {
    @@ -2168,7 +2168,7 @@ copcsr:
    DPFROMREG(ft, MIPSInst_FT(ir));
    DPFROMREG(fs, MIPSInst_FS(ir));
    rv.d = ieee754dp_fmax(fs, ft);
    - break;
    + goto copcsr;
    }

    case fmaxa_op: {
    @@ -2180,7 +2180,7 @@ copcsr:
    DPFROMREG(ft, MIPSInst_FT(ir));
    DPFROMREG(fs, MIPSInst_FS(ir));
    rv.d = ieee754dp_fmaxa(fs, ft);
    - break;
    + goto copcsr;
    }

    case fabs_op:

    \
     
     \ /
      Last update: 2017-12-22 11:34    [W:4.145 / U:0.380 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site