Messages in this thread | | | Date | Thu, 21 Dec 2017 11:57:13 -0600 | From | "Serge E. Hallyn" <> | Subject | Re: [PATCH] Smack: fix dereferenced before check |
| |
Quoting Vasyl Gomonovych (gomonovych@gmail.com): > This patch fixes the warning reported by smatch: > security/smack/smack_lsm.c:2872 smack_socket_connect() warn: > variable dereferenced before check 'sock->sk' (see line 2869) > > Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>
Looks obviously correct - thanks.
Acked-by: Serge Hallyn <serge@hallyn.com>
> --- > security/smack/smack_lsm.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c > index 14cc7940b36d..30f2c3d1c11c 100644 > --- a/security/smack/smack_lsm.c > +++ b/security/smack/smack_lsm.c > @@ -2866,12 +2866,16 @@ static int smack_socket_connect(struct socket *sock, struct sockaddr *sap, > #endif > #ifdef SMACK_IPV6_SECMARK_LABELING > struct smack_known *rsp; > - struct socket_smack *ssp = sock->sk->sk_security; > + struct socket_smack *ssp; > #endif > > if (sock->sk == NULL) > return 0; > > +#ifdef SMACK_IPV6_SECMARK_LABELING > + ssp = sock->sk->sk_security; > +#endif > + > switch (sock->sk->sk_family) { > case PF_INET: > if (addrlen < sizeof(struct sockaddr_in)) > -- > 1.9.1
| |