Messages in this thread | | | From | David Laight <> | Subject | RE: [PATCH v10 1/3] lib: Add strongly typed 64bit int_sqrt | Date | Thu, 21 Dec 2017 13:56:55 +0000 |
| |
From: Crt Mori > Sent: 21 December 2017 13:18 ... > > unsigned int i; > > i can be u8. And I will still use explicit typing.
u8 will add extra code, unsigned int is good. 'x' needs to be u32, 'y' and 'b' could be larger.
I was testing in userspace.
... > This part above looks like FLS It also does the rest of the required shifts.
... > This one indeed works. I did some more testing this morning and I am > fine with either. > > So question is: Do I make change as per David's suggestion with his > sign-off, or leave the version it was before the change?
If you generate the actual patch I can add an appropriate sign-off (or whatever is needed).
David
| |