lkml.org 
[lkml]   [2017]   [Dec]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v4 07/36] hrtimer: Cleanup hrtimer_mode enum
    Date
    It's not obvious that the HRTIMER_MODE variants are bit combinations
    because all modes are hard coded constants.

    Change it so the bit meanings are clear and use the symbols for creating
    modes which combine bits.

    While at it get rid of the ugly tail comments.

    Signed-off-by: Anna-Maria Gleixner <anna-maria@linutronix.de>
    ---
    include/linux/hrtimer.h | 16 +++++++++++-----
    1 file changed, 11 insertions(+), 5 deletions(-)

    diff --git a/include/linux/hrtimer.h b/include/linux/hrtimer.h
    index 4e6a8841dcbe..28f267cf2851 100644
    --- a/include/linux/hrtimer.h
    +++ b/include/linux/hrtimer.h
    @@ -28,13 +28,19 @@ struct hrtimer_cpu_base;

    /*
    * Mode arguments of xxx_hrtimer functions:
    + *
    + * HRTIMER_MODE_ABS - Time value is absolute
    + * HRTIMER_MODE_REL - Time value is relative to now
    + * HRTIMER_MODE_PINNED - Timer is bound to CPU (is only considered
    + * when starting the timer)
    */
    enum hrtimer_mode {
    - HRTIMER_MODE_ABS = 0x0, /* Time value is absolute */
    - HRTIMER_MODE_REL = 0x1, /* Time value is relative to now */
    - HRTIMER_MODE_PINNED = 0x02, /* Timer is bound to CPU */
    - HRTIMER_MODE_ABS_PINNED = 0x02,
    - HRTIMER_MODE_REL_PINNED = 0x03,
    + HRTIMER_MODE_ABS = 0x00,
    + HRTIMER_MODE_REL = 0x01,
    + HRTIMER_MODE_PINNED = 0x02,
    +
    + HRTIMER_MODE_ABS_PINNED = HRTIMER_MODE_ABS | HRTIMER_MODE_PINNED,
    + HRTIMER_MODE_REL_PINNED = HRTIMER_MODE_REL | HRTIMER_MODE_PINNED,
    };

    /*
    --
    2.11.0
    \
     
     \ /
      Last update: 2017-12-21 11:52    [W:4.309 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site