lkml.org 
[lkml]   [2017]   [Dec]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL for 4.9 23/33] atm: horizon: Fix irq release error
    Date
    From: Arvind Yadav <arvind.yadav.cs@gmail.com>

    [ Upstream commit bde533f2ea607cbbbe76ef8738b36243939a7bc2 ]

    atm_dev_register() can fail here and passed parameters to free irq
    which is not initialised. Initialization of 'dev->irq' happened after
    the 'goto out_free_irq'. So using 'irq' insted of 'dev->irq' in
    free_irq().

    Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
    ---
    drivers/atm/horizon.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/atm/horizon.c b/drivers/atm/horizon.c
    index 5fc81e240c24..e55f418d6ab9 100644
    --- a/drivers/atm/horizon.c
    +++ b/drivers/atm/horizon.c
    @@ -2802,7 +2802,7 @@ out:
    return err;

    out_free_irq:
    - free_irq(dev->irq, dev);
    + free_irq(irq, dev);
    out_free:
    kfree(dev);
    out_release:
    --
    2.11.0
    \
     
     \ /
      Last update: 2017-12-02 17:09    [W:2.224 / U:0.124 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site