Messages in this thread | | | Subject | Re: [PATCH 2/3] mmc: sdhci-pci-o2micro: Add eMMC HS200 support | From | Adrian Hunter <> | Date | Tue, 19 Dec 2017 10:02:46 +0200 |
| |
On 04/12/17 12:10, LinuxPatchCommit wrote: > Dear all,
A greeting is not needed in a commit message.
> > Add register definition for eMMC HS200 mode. > Add hardware tuning for eMMC HS200 mode. > > Signed-off-by: ernest.zhang <ernest.zhang@bayhubtech.com> > --- > drivers/mmc/host/sdhci-pci-o2micro.h | 3 +++
sdhci-pci-o2micro.h was removed by commit 361eeda0ca16 ("mmc: sdhci-pci: Tidy o2micro definitions"). Please re-base.
> 1 file changed, 3 insertions(+) > > diff --git a/drivers/mmc/host/sdhci-pci-o2micro.h b/drivers/mmc/host/sdhci-pci-o2micro.h > index 770f53857211..3fb957729315 100644 > --- a/drivers/mmc/host/sdhci-pci-o2micro.h > +++ b/drivers/mmc/host/sdhci-pci-o2micro.h > @@ -49,6 +49,7 @@ > #define O2_SD_MISC_CTRL4 0xFC > #define O2_SD_TUNING_CTRL 0x300 > #define O2_SD_PLL_SETTING 0x304 > +#define O2_SD_MISC_SETTING 0x308 > #define O2_SD_CLK_SETTING 0x328 > #define O2_SD_CAP_REG2 0x330 > #define O2_SD_CAP_REG0 0x334 > @@ -62,6 +63,8 @@ > #define O2_SD_FREG4_ENABLE_CLK_SET BIT(22) > > #define O2_SD_VENDOR_SETTING 0x110 > +#define O2_SD_HW_TUNING_ENABLE BIT(4)
Both these definitions are needed in patch 1. It would be better to add them in that patch.
> + > #define O2_SD_VENDOR_SETTING2 0x1C8 > > extern int sdhci_pci_o2_probe_slot(struct sdhci_pci_slot *slot); >
| |