lkml.org 
[lkml]   [2017]   [Dec]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 0/2] platform/x86/thinkpad_acpi: Adjustments for four function implementations
    On Mon, Dec 18, 2017 at 11:26 PM, SF Markus Elfring
    <elfring@users.sourceforge.net> wrote:
    > From: Markus Elfring <elfring@users.sourceforge.net>
    > Date: Mon, 18 Dec 2017 22:23:45 +0100
    >
    > Two update suggestions were taken into account
    > from static source code analysis.
    >
    > Markus Elfring (2):
    > Delete an error message for a failed memory allocation in three functions

    This one is questionable since it prints error messages at ->init() stage.
    I would rather not touch this.

    > Improve a size determination in tpacpi_new_rfkill()

    Doesn't make any sense right now. One style over the other.
    Nothing gets better or worth at this point.

    Sorry, but NAK for both.

    --
    With Best Regards,
    Andy Shevchenko

    \
     
     \ /
      Last update: 2017-12-19 15:38    [W:3.219 / U:0.272 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site