Messages in this thread | | | Subject | Re: [Xen-devel] [PATCH v2] xen/balloon: Mark unallocated host memory as UNUSABLE | From | Juergen Gross <> | Date | Tue, 19 Dec 2017 11:08:25 +0100 |
| |
On 19/12/17 10:27, Jan Beulich wrote: >>>> On 19.12.17 at 10:21, <jgross@suse.com> wrote: >> On 19/12/17 09:23, Jan Beulich wrote: >>>>>> On 18.12.17 at 23:22, <boris.ostrovsky@oracle.com> wrote: >>>> +void __init arch_xen_balloon_init(struct resource *hostmem_resource) >>>> +{ >>>> + struct xen_memory_map memmap; >>>> + int rc; >>>> + unsigned int i, last_guest_ram; >>>> + phys_addr_t max_addr = max_pfn << PAGE_SHIFT; >>> >>> PFN_PHYS() as right now you still have an issue on 32-bit. >> >> Why? PFN_PHYS is defined as: >> >> #define PFN_PHYS(x) ((phys_addr_t)(x) << PAGE_SHIFT) > > Well, that's why I suggested its use (just like you did in your > own review). IOW - now I'm confused.
Sorry, just got your answer wrong.
As I had already found the same issue somehow I assumked this remark would be referencing my review. Sorry for the noise.
Juergen
| |