lkml.org 
[lkml]   [2017]   [Dec]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -tip v3 3/6] net: sctp: Add SCTP ACK tracking trace event
On Tue, 19 Dec 2017 10:20:24 -0500
Steven Rostedt <rostedt@goodmis.org> wrote:

> On Tue, 19 Dec 2017 17:58:25 +0900
> Masami Hiramatsu <mhiramat@kernel.org> wrote:
>
> > +TRACE_EVENT(sctp_probe,
> > +
> > + TP_PROTO(const struct sctp_endpoint *ep,
> > + const struct sctp_association *asoc,
> > + struct sctp_chunk *chunk),
> > +
> > + TP_ARGS(ep, asoc, chunk),
> > +
> > + TP_STRUCT__entry(
> > + __field(__u64, asoc)
> > + __field(__u32, mark)
> > + __field(__u16, bind_port)
> > + __field(__u16, peer_port)
> > + __field(__u32, pathmtu)
> > + __field(__u32, rwnd)
> > + __field(__u16, unack_data)
> > + ),
> > +
> > + TP_fast_assign(
> > + struct sctp_transport *sp;
> > + struct sk_buff *skb = chunk->skb;
> > +
> > + __entry->asoc = (__u64)asoc;
> > + __entry->mark = skb->mark;
> > + __entry->bind_port = ep->base.bind_addr.port;
> > + __entry->peer_port = asoc->peer.port;
> > + __entry->pathmtu = asoc->pathmtu;
> > + __entry->rwnd = asoc->peer.rwnd;
> > + __entry->unack_data = asoc->unack_data;
> > +
> > + if (trace_sctp_probe_path_enabled()) {
> > + list_for_each_entry(sp, &asoc->peer.transport_addr_list,
> > + transports) {
> > + trace_sctp_probe_path(sp, asoc);
> > + }
> > + }
>
> I thought you were going to move this into the code, like I suggested?

Ah, I missed to define sp in the block...

Thanks,

>
> -- Steve
>
> > + ),
> > +
> > + TP_printk("asoc=%#llx mark=%#x bind_port=%d peer_port=%d pathmtu=%d "
> > + "rwnd=%u unack_data=%d",
> > + __entry->asoc, __entry->mark, __entry->bind_port,
> > + __entry->peer_port, __entry->pathmtu, __entry->rwnd,
> > + __entry->unack_data)
> > +);
> > +


--
Masami Hiramatsu <mhiramat@kernel.org>

\
 
 \ /
  Last update: 2017-12-20 02:05    [W:0.084 / U:0.244 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site