lkml.org 
[lkml]   [2017]   [Dec]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 089/178] media: camss-vfe: always initialize reg at vfe_set_xbar_cfg()
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Mauro Carvalho Chehab <mchehab@s-opensource.com>


    [ Upstream commit 9917fbcfa20ab987d6381fd0365665e5c1402d75 ]

    if output->wm_num is bigger than 2, the value for reg is
    not initialized, as warned by smatch:
    drivers/media/platform/qcom/camss-8x16/camss-vfe.c:633 vfe_set_xbar_cfg() error: uninitialized symbol 'reg'.
    drivers/media/platform/qcom/camss-8x16/camss-vfe.c:637 vfe_set_xbar_cfg() error: uninitialized symbol 'reg'.

    That shouldn't happen in practice, so add a logic that will
    break the loop if i > 1, fixing the warnings.

    Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
    Acked-by: Todor Tomov <todor.tomov@linaro.org>
    Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/media/platform/qcom/camss-8x16/camss-vfe.c | 3 +++
    1 file changed, 3 insertions(+)

    --- a/drivers/media/platform/qcom/camss-8x16/camss-vfe.c
    +++ b/drivers/media/platform/qcom/camss-8x16/camss-vfe.c
    @@ -622,6 +622,9 @@ static void vfe_set_xbar_cfg(struct vfe_
    reg = VFE_0_BUS_XBAR_CFG_x_M_PAIR_STREAM_EN;
    if (p == V4L2_PIX_FMT_NV12 || p == V4L2_PIX_FMT_NV16)
    reg |= VFE_0_BUS_XBAR_CFG_x_M_PAIR_STREAM_SWAP_INTER_INTRA;
    + } else {
    + /* On current devices output->wm_num is always <= 2 */
    + break;
    }

    if (output->wm_idx[i] % 2 == 1)

    \
     
     \ /
      Last update: 2017-12-18 17:41    [W:3.580 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site