lkml.org 
[lkml]   [2017]   [Dec]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/5] media: rc: update sunxi-ir driver to get base clock frequency from devicetree
From
Date
Hey Andi,

thanks for the feedback. I will fix that in the next version of this
patch series!

On 18.12.2017 03:44, Andi Shyti wrote:
> Hi Philipp,
>
> just a couple of small nitpicks.
>
>> + u32 b_clk_freq;
>
> [...]
>
>> + /* Base clock frequency (optional) */
>> + if (of_property_read_u32(dn, "clock-frequency", &b_clk_freq)) {
>> + b_clk_freq = SUNXI_IR_BASE_CLK;
>> + }
>> +
>
> how about you intialize 'b_clk_freq' to 'SUNXI_IR_BASE_CLK' and
> just call 'of_property_read_u32' without if statement.
> 'b_clk_freq' value should not be changed if "clock-frequency"
> is not present in the DTS.
>
> This might avoid misinterpretation from static analyzers that
> might think that 'b_clk_freq' is used uninitialized.
>
>> + dev_info(dev, "set base clock frequency to %d Hz.\n", b_clk_freq);
>
> Please use dev_dbg().
>
> Andi
>
--
Philipp

\
 
 \ /
  Last update: 2017-12-18 13:44    [W:0.075 / U:1.292 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site