Messages in this thread | | | Subject | Re: [PATCH 2/2] ps3: Improve a size determination in five functions | From | Geoff Levand <> | Date | Mon, 18 Dec 2017 10:22:27 -0800 |
| |
Hi,
On 12/16/2017 05:54 AM, SF Markus Elfring wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Sat, 16 Dec 2017 14:21:04 +0100 > > Replace the specification of data structures by variable references > as the parameter for the operator "sizeof" to make the corresponding size > determination a bit safer according to the Linux coding style convention.
This would be OK, but you are also removing empty lines and changing the coding format.
Please update the patch to only make the sizeof changes.
-Geoff
| |