lkml.org 
[lkml]   [2017]   [Dec]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 031/177] bnxt_en: Ignore 0 value in autoneg supported speed from firmware.
    Date
    4.9-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Michael Chan <michael.chan@broadcom.com>


    [ Upstream commit 520ad89a54edea84496695d528f73ddcf4a52ea4 ]

    In some situations, the firmware will return 0 for autoneg supported
    speed. This may happen if the firmware detects no SFP module, for
    example. The driver should ignore this so that we don't end up with
    an invalid autoneg setting with nothing advertised. When SFP module
    is inserted, we'll get the updated settings from firmware at that time.

    Signed-off-by: Michael Chan <michael.chan@broadcom.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/ethernet/broadcom/bnxt/bnxt.c | 5 +++--
    1 file changed, 3 insertions(+), 2 deletions(-)

    --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
    +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
    @@ -5132,8 +5132,9 @@ static int bnxt_hwrm_phy_qcaps(struct bn
    bp->lpi_tmr_hi = le32_to_cpu(resp->valid_tx_lpi_timer_high) &
    PORT_PHY_QCAPS_RESP_TX_LPI_TIMER_HIGH_MASK;
    }
    - link_info->support_auto_speeds =
    - le16_to_cpu(resp->supported_speeds_auto_mode);
    + if (resp->supported_speeds_auto_mode)
    + link_info->support_auto_speeds =
    + le16_to_cpu(resp->supported_speeds_auto_mode);

    hwrm_phy_qcaps_exit:
    mutex_unlock(&bp->hwrm_cmd_lock);

    \
     
     \ /
      Last update: 2017-12-18 18:38    [W:3.913 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site