lkml.org 
[lkml]   [2017]   [Dec]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 128/177] target/file: Do not return error for UNMAP if length is zero
    Date
    4.9-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Jiang Yi <jiangyilism@gmail.com>


    [ Upstream commit 594e25e73440863981032d76c9b1e33409ceff6e ]

    The function fd_execute_unmap() in target_core_file.c calles

    ret = file->f_op->fallocate(file, mode, pos, len);

    Some filesystems implement fallocate() to return error if
    length is zero (e.g. btrfs) but according to SCSI Block
    Commands spec UNMAP should return success for zero length.

    Signed-off-by: Jiang Yi <jiangyilism@gmail.com>
    Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
    Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/target/target_core_file.c | 4 ++++
    1 file changed, 4 insertions(+)

    --- a/drivers/target/target_core_file.c
    +++ b/drivers/target/target_core_file.c
    @@ -466,6 +466,10 @@ fd_execute_unmap(struct se_cmd *cmd, sec
    struct inode *inode = file->f_mapping->host;
    int ret;

    + if (!nolb) {
    + return 0;
    + }
    +
    if (cmd->se_dev->dev_attrib.pi_prot_type) {
    ret = fd_do_prot_unmap(cmd, lba, nolb);
    if (ret)

    \
     
     \ /
      Last update: 2017-12-18 18:09    [W:3.195 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site