Messages in this thread | | | Date | Sat, 16 Dec 2017 09:49:33 -0800 | From | Nicolin Chen <> | Subject | Re: [PATCH v3 03/11] ASoC: fsl_ssi: Refine all comments |
| |
On Sat, Dec 16, 2017 at 09:30:14AM -0800, Caleb Crome wrote:
> Having come to work on this driver with very little knowledge about > kernel programming, and i.MX, I have to agree with Timur. It's an > amazingly complex driver (with support of so many variants). By > eliminating verbose commentary, it's also wiping away a lot of > knowledge. The more sparse commentary makes things harder to > understand for newcomers, or really anybody who isn't already steeped > in knowledge about the SSI port and linux, and it's interaction with > DMA.
I never said that I don't agree with Timur. Every change here is to simplify things. As long as Timur or any reviewer feels one of new comments is harder to understand, I am totally fine to rework. I respect everyone's opinion, but I hope everyone can respect my effort too by telling me which one needs to rework and why?
Thanks Nicolin
| |