lkml.org 
[lkml]   [2017]   [Dec]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 4/5] rds: Add runchecks.cfg for net/rds
    On Sat, 16 Dec 2017 15:42:29 +0100
    Knut Omang <knut.omang@oracle.com> wrote:

    > +
    > +# Important to fix from a quality perspective:
    > +#
    > +except AVOID_BUG connection.c ib.c ib_cm.c ib_rdma.c ib_recv.c ib_ring.c ib_send.c info.c loop.c message.c
    > +except AVOID_BUG rdma.c recv.c send.c stats.c tcp_recv.c transport.c
    > +except MEMORY_BARRIER ib_recv.c send.c tcp_send.c
    > +except WAITQUEUE_ACTIVE cong.c ib_rdma.c ib_ring.c ib_send.c
    > +except UNNECESSARY_ELSE bind.c ib_cm.c
    > +except MACRO_ARG_PRECEDENCE connection.c ib.h rds.h
    > +except MACRO_ARG_REUSE rds.h
    > +except ALLOC_SIZEOF_STRUCT cong.c ib.c ib_cm.c loop.c message.c rdma.c
    > +except UNCOMMENTED_DEFINITION ib_cm.c
    > +
    > +# Code simplification:
    > +#
    > +except ALLOC_WITH_MULTIPLY ib.c
    > +except PREFER_PR_LEVEL ib_cm.c ib_recv.c ib_send.c rdma_transport.c threads.c transport.c
    > +except UNNECESSARY_ELSE ib_fmr.c
    > +except UNNECESSARY_PARENTHESES ib_rdma.c rdma.c recv.c send.c
    > +except PRINTK_RATELIMITED ib_frmr.c
    > +except EMBEDDED_FUNCTION_NAME ib_rdma.c
    > +
    > +# Style and readability:
    > +#
    > +except BRACES ib_cm.c ib_rdma.c ib_recv.c send.c transport.c
    > +except OOM_MESSAGE ib.c tcp.c
    > +except LONG_LINE_STRING ib.c ib_recv.c ib_send.c
    > +except FUNCTION_ARGUMENTS ib.h ib_mr.h rds.h tcp.h
    > +except OPEN_ENDED_LINE recv.c ib_recv.c
    > +
    > +# Candidates to leave as exceptions (don't fix):
    > +except MULTIPLE_ASSIGNMENTS ib_send.c
    > +except LONG_LINE_STRING connection.c
    > +except OPEN_BRACE connection.c
    > +

    Why start letting subsystems have a free-pass?
    Also this would mean that new patches to IB would continue the bad habits.

    \
     
     \ /
      Last update: 2017-12-16 18:46    [W:5.309 / U:0.076 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site