Messages in this thread | | | Date | Fri, 15 Dec 2017 13:51:17 -0500 (EST) | Subject | Re: [PATCH net-next] net: phy: phylink: Handle NULL fwnode_handle | From | David Miller <> |
| |
From: Florian Fainelli <f.fainelli@gmail.com> Date: Thu, 14 Dec 2017 15:57:58 -0800
> Unlike the various of_* routines to fetch properties, fwnode_* routines can > have an early check against a NULL fwnode_handle reference which makes them > return -EINVAL (see fwnode_call_int_op), thus making it virtually impossible to > differentiate what type of error is going on. > > Have an early check in phylink_register_sfp() so we can keep proceeding with > the initialization, there is not much we can do without a valid fwnode_handle > except return early and treat this similarly to -ENOENT. > > Fixes: 8fa7b9b6af25 ("phylink: convert to fwnode") > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Applied.
| |