Messages in this thread | | | From | William Tu <> | Date | Fri, 15 Dec 2017 08:26:54 -0800 | Subject | Re: [PATCH] ip_gre: fix wrong return value of erspan_rcv |
| |
On Thu, Dec 14, 2017 at 6:46 PM, Haishuang Yan <yanhaishuang@cmss.chinamobile.com> wrote: > If pskb_may_pull return failed, return PACKET_REJECT instead of -ENOMEM. > > Fixes: 84e54fe0a5ea ("gre: introduce native tunnel support for ERSPAN") > Cc: William Tu <u9012063@gmail.com> > Signed-off-by: Haishuang Yan <yanhaishuang@cmss.chinamobile.com> > ---
Thanks for the patch. I think the other way is simply to just 'goto drop', freeing the skb in erspan_rcv(), instead of 'return PACKET_REJECT'. I'm ok either way.
Acked-by: William Tu <u9012063@gmail.com>
| |