Messages in this thread | | | Subject | Re: [PATCH V2] ACPI / LPSS: Add device link for CHT SD card dependency on I2C | From | Andy Shevchenko <> | Date | Fri, 15 Dec 2017 12:03:37 +0200 |
| |
On Fri, 2017-12-15 at 01:58 +0100, Rafael J. Wysocki wrote: > On Thu, Dec 14, 2017 at 3:16 PM, Andy Shevchenko > <andriy.shevchenko@linux.intel.com> wrote: > > On Thu, 2017-12-07 at 11:03 +0200, Adrian Hunter wrote: > > >
> > > > > > +static const struct x86_cpu_id cht_cpu[] = { > > > + ICPU(INTEL_FAM6_ATOM_AIRMONT), /* Braswell, Cherry > > > Trail */ > > > + {} > > > +}; > > > > I would rather to modify ICPU() macro to accept driver data where we > > just pass an unsigned long value to be assigned as lpss_quirks and > > introduce another quirk. > > Not really. > > There are many instances of ICPU() already in the tree and updating > all of them is just not worth it.
These macros all over the code are local. I'm talking about one which is defined inside acpi_lpss.c.
-- Andy Shevchenko <andriy.shevchenko@linux.intel.com> Intel Finland Oy
| |