lkml.org 
[lkml]   [2017]   [Dec]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.18 21/64] kdb: Fix handling of kallsyms_symbol_next() return value
    Date
    3.18-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Daniel Thompson <daniel.thompson@linaro.org>

    commit c07d35338081d107e57cf37572d8cc931a8e32e2 upstream.

    kallsyms_symbol_next() returns a boolean (true on success). Currently
    kdb_read() tests the return value with an inequality that
    unconditionally evaluates to true.

    This is fixed in the obvious way and, since the conditional branch is
    supposed to be unreachable, we also add a WARN_ON().

    Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>
    Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    kernel/debug/kdb/kdb_io.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/kernel/debug/kdb/kdb_io.c
    +++ b/kernel/debug/kdb/kdb_io.c
    @@ -349,7 +349,7 @@ poll_again:
    }
    kdb_printf("\n");
    for (i = 0; i < count; i++) {
    - if (kallsyms_symbol_next(p_tmp, i) < 0)
    + if (WARN_ON(!kallsyms_symbol_next(p_tmp, i)))
    break;
    kdb_printf("%s ", p_tmp);
    *(p_tmp + len) = '\0';

    \
     
     \ /
      Last update: 2017-12-15 10:30    [W:2.721 / U:0.096 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site