Messages in this thread | | | Subject | Re: [PATCH 1/2][RFC]Ktest: Add email support | From | Tim Tianyang Chen <> | Date | Thu, 14 Dec 2017 16:11:25 -0800 |
| |
Thanks for the review Steven! > First comment is that the numbered patches need to be a reply to the > cover patch (that is patches 1/2 and 2/2 need to be replies of 0/2). > Otherwise, my mailer loses them, because I always have my email sorted > by threads, and a reply to 0/2 will move it away from the other patches > if the other patches are not replies. Not sure what happened. I used --thread option for git send-email, and in thunderbird I can see all the patches in one thread replying to 0/2. > Hmm, I'm thinking it doesn't get sent when we hit Ctrl-C. Or at last > have these as options to when to send them. > > I think by default, it should only send when finished, or failed. But > have options like: > > EMAIL_WHEN_STARTED, EMAIL_WHEN_CANCELED (both default false) > EMAIL_WHEN_FINIHSED and EMAIL_ON_ERROR (both default true). Yeah. It's a good idea to add them as options.
Thanks, Tim
| |