lkml.org 
[lkml]   [2017]   [Dec]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 4/8] staging: pi433: add parentheses to mask and shift
    Fixes checkpatch warning:

    WARNING: Possible precedence defect with mask then right shift - may need parentheses

    Signed-off-by: Valentin Vidic <Valentin.Vidic@CARNet.hr>
    ---
    drivers/staging/pi433/rf69.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c
    index f77ecd60f43a..b1e243e5bcac 100644
    --- a/drivers/staging/pi433/rf69.c
    +++ b/drivers/staging/pi433/rf69.c
    @@ -102,7 +102,7 @@ enum modulation rf69_get_modulation(struct spi_device *spi)

    currentValue = rf69_read_reg(spi, REG_DATAMODUL);

    - switch (currentValue & MASK_DATAMODUL_MODULATION_TYPE >> 3) { // TODO improvement: change 3 to define
    + switch ((currentValue & MASK_DATAMODUL_MODULATION_TYPE) >> 3) { // TODO improvement: change 3 to define
    case DATAMODUL_MODULATION_TYPE_OOK: return OOK;
    case DATAMODUL_MODULATION_TYPE_FSK: return FSK;
    default: return UNDEF;
    @@ -340,7 +340,7 @@ enum lnaGain rf69_get_lna_gain(struct spi_device *spi)

    currentValue = rf69_read_reg(spi, REG_LNA);

    - switch (currentValue & MASK_LNA_CURRENT_GAIN >> 3) { // improvement: change 3 to define
    + switch ((currentValue & MASK_LNA_CURRENT_GAIN) >> 3) { // improvement: change 3 to define
    case LNA_GAIN_AUTO: return automatic;
    case LNA_GAIN_MAX: return max;
    case LNA_GAIN_MAX_MINUS_6: return maxMinus6;
    --
    2.15.0
    \
     
     \ /
      Last update: 2017-12-13 16:08    [W:5.505 / U:0.132 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site