lkml.org 
[lkml]   [2017]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 5/5] perf-probe: Support escaped character in parser
Em Tue, Dec 12, 2017 at 11:46:00PM +0900, Masami Hiramatsu escreveu:
> On Mon, 11 Dec 2017 17:03:30 -0300
> Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> > > - /* We don't care about default symbol or not */
> > > - ver = strchr(norm, '@');
> > > - if (ver) {
> > > - buf = strndup(norm, ver - norm);
> > > - if (!buf)
> > > - return -ENOMEM;
> > > - norm = buf;
> > > + if (cut_version) {
> > > + /* We don't care about default symbol or not */
> > > + ver = strchr(norm, '@');
> > > + if (ver) {
> > > + buf = strndup(norm, ver - norm);
> > > + if (!buf)
> > > + return -ENOMEM;
> > > + norm = buf;

> > You forgot a } here, please check this logic and resubmit just this last
> > patch, without the string.c and string2.h part, that I already split
> > from this one and applied.

> OOPS! thanks! I missed something around that.... maybe while updating patches.
> Hmm, I might be so upset...

> OK, anyway, I'll do that.

Nah, happens sometimes, one last round of building before submitting
would catch that tho... 8-) :-)

- Arnaldo

\
 
 \ /
  Last update: 2017-12-12 16:02    [W:0.037 / U:4.292 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site