lkml.org 
[lkml]   [2017]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 120/164] dynamic-debug-howto: fix optional/omitted ending line number to be LARGE instead of 0
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Randy Dunlap <rdunlap@infradead.org>


    [ Upstream commit 1f3c790bd5989fcfec9e53ad8fa09f5b740c958f ]

    line-range is supposed to treat "1-" as "1-endoffile", so
    handle the special case by setting last_lineno to UINT_MAX.

    Fixes this error:

    dynamic_debug:ddebug_parse_query: last-line:0 < 1st-line:1
    dynamic_debug:ddebug_exec_query: query parse failed

    Link: http://lkml.kernel.org/r/10a6a101-e2be-209f-1f41-54637824788e@infradead.org
    Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
    Acked-by: Jason Baron <jbaron@akamai.com>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    lib/dynamic_debug.c | 4 ++++
    1 file changed, 4 insertions(+)

    --- a/lib/dynamic_debug.c
    +++ b/lib/dynamic_debug.c
    @@ -360,6 +360,10 @@ static int ddebug_parse_query(char *word
    if (parse_lineno(last, &query->last_lineno) < 0)
    return -EINVAL;

    + /* special case for last lineno not specified */
    + if (query->last_lineno == 0)
    + query->last_lineno = UINT_MAX;
    +
    if (query->last_lineno < query->first_lineno) {
    pr_err("last-line:%d < 1st-line:%d\n",
    query->last_lineno,

    \
     
     \ /
      Last update: 2017-12-12 14:47    [W:4.020 / U:0.192 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site