lkml.org 
[lkml]   [2017]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v1 1/2] drm/tegra: dc: Link DC1 to DC0 on Tegra20
From
Date
On 11.12.2017 13:12, Thierry Reding wrote:
> On Mon, Dec 11, 2017 at 02:19:43AM +0300, Dmitry Osipenko wrote:
>> HW reset isn't actually broken on Tegra20, but there is a dependency on
>> first display controller to be taken out of reset for the second to be
>> enabled successfully.
>>
>> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
>> ---
>> drivers/gpu/drm/tegra/dc.c | 77 +++++++++++++++++++++++++++++-----------------
>> drivers/gpu/drm/tegra/dc.h | 4 ++-
>> 2 files changed, 51 insertions(+), 30 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/tegra/dc.c b/drivers/gpu/drm/tegra/dc.c
>> index fc70351b9017..6139d3e9cedf 100644
>> --- a/drivers/gpu/drm/tegra/dc.c
>> +++ b/drivers/gpu/drm/tegra/dc.c
>> @@ -24,6 +24,8 @@
>> #include <drm/drm_atomic_helper.h>
>> #include <drm/drm_plane_helper.h>
>>
>> +static struct tegra_dc *dc0;
>
> I'd like to avoid the global variable. Perhaps you can use the
> driver_for_each_device() or driver_find_device() functions to find the
> correct device?

driver_find_device() fit perfectly, thank you for the suggestion.

\
 
 \ /
  Last update: 2017-12-11 16:00    [W:0.794 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site