Messages in this thread | | | Subject | Re: [PATCH] Fix resume on x86-32 machines | From | Jarkko Nikula <> | Date | Mon, 11 Dec 2017 16:59:11 +0200 |
| |
On 12/11/2017 04:22 PM, Rafael J. Wysocki wrote: > On Sunday, December 10, 2017 10:58:23 PM CET Andy Lutomirski wrote: >> >>> On Dec 10, 2017, at 1:38 PM, Pavel Machek <pavel@ucw.cz> wrote: >>> >>> >>> After 4.15-rc2, suspend stopped working on Thinkpad X60. 5b06bbc >>> (unintentionally?) reordered stuff with respect to >>> fix_processor_context() on 32-bit and 64-bit. We undo that change on >>> 32-bit. >>> >> >> Can you explain what was wrong with the reordering? Your patch certainly *looks* incorrect. >> >> I'm guessing that the real issue is that 32-bit needs %fs restored early for TLS. > > I *think* you are right. > > Anyway, that should be easy enough to verify. > > Pavel, can you please check if the below change works too? > > --- > arch/x86/power/cpu.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > Works here on my test machine.
Tested-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
| |