lkml.org 
[lkml]   [2017]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH net-next v5 2/2] net: ethernet: socionext: add AVE ethernet driver
    On Mon, Dec 11, 2017 at 10:34:17PM +0900, Masami Hiramatsu wrote:
    > IMHO, even if we use SPDX license identifier, I recommend to use
    > C-style comments as many other files do, since it is C code.
    > If SPDX identifier requires C++ style, that is SPDX parser's issue
    > and should be fixed to get it from C-style comment.

    See the numerous emails on this subject already. The issue of C
    vs C++ comments has come up many times by many different people, but
    the result is the same. That's not going to happen. Linux kernel
    C files are required to use "//" for the SPDX identifier by order
    of Linus Torvalds.

    Linus has also revealed in that discussion that he has a preference
    for "//" style commenting for single comments, so it seems that the
    kernel coding style may change - but there is no desire for patches
    to "clean up" single line comments to use "//".

    For further information, and to see the discussion that has already
    happened, the arguments that have been made about style, see the
    threads for the patch series that tglx has been posting wrt documenting
    the SPDX stuff for the kernel.

    Thanks (let's stop rehashing the same arguments.)

    --
    RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
    FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up
    According to speedtest.net: 8.21Mbps down 510kbps up

    \
     
     \ /
      Last update: 2017-12-11 14:48    [W:2.453 / U:0.140 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site