Messages in this thread Patch in this message | | | From | Arnd Bergmann <> | Subject | [PATCH] dm: fix uninitialized variable reference | Date | Mon, 11 Dec 2017 12:33:45 +0100 |
| |
The last bugfix apparently introduced another problem, as shown by this gcc warning:
drivers/md/dm.c: In function '__send_changing_extent_only': drivers/md/dm.c:1365:28: error: 'ti' is used uninitialized in this function [-Werror=uninitialized]
This restores the intialization of the 'ti' variable.
Fixes: aecefd4919de ("dm: fix __send_changing_extent_only() to send first bio and chain remainder") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- I did not test this or give the patch much thought, this just seemed to be the most likely fix I could come up with in a short time, so please review carefully, and ignore if the solution is something else. --- drivers/md/dm.c | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/drivers/md/dm.c b/drivers/md/dm.c index 05aa9c094352..f19e9787076e 100644 --- a/drivers/md/dm.c +++ b/drivers/md/dm.c @@ -1356,6 +1356,10 @@ static int __send_changing_extent_only(struct clone_info *ci, unsigned len; unsigned num_bios; + ti = dm_table_find_target(ci->map, ci->sector); + if (!dm_target_is_valid(ti)) + return -EIO; + /* * Even though the device advertised support for this type of * request, that does not mean every target supports it, and -- 2.9.0
| |