Messages in this thread | | | Date | Mon, 11 Dec 2017 11:13:43 +0100 | From | Thierry Reding <> | Subject | Re: [PATCH v1 2/2] drm/tegra: Support disabled CONFIG_PM |
| |
On Mon, Dec 11, 2017 at 02:19:44AM +0300, Dmitry Osipenko wrote: > Add manual HW power management to drivers probe/remove in order to > not fail in a case of runtime power management being disabled in kernel > config. > > Signed-off-by: Dmitry Osipenko <digetx@gmail.com> > --- > drivers/gpu/drm/tegra/dc.c | 164 +++++++++++++++++++++++++++---------------- > drivers/gpu/drm/tegra/dsi.c | 138 +++++++++++++++++++++--------------- > drivers/gpu/drm/tegra/hdmi.c | 90 ++++++++++++++++-------- > drivers/gpu/drm/tegra/sor.c | 103 +++++++++++++++++---------- > 4 files changed, 310 insertions(+), 185 deletions(-)
I think that's the wrong way around. We unconditionally select PM on 64-bit ARM already, and I think we should do the same on 32-bit ARM. There's really no excuse not to enable runtime PM these days.
Thierry [unhandled content-type:application/pgp-signature] | |