Messages in this thread | | | Date | Mon, 11 Dec 2017 10:18:05 +0100 | From | Florian Westphal <> | Subject | Re: [PATCH][netfilter-next] netfilter: conntrack: make struct nf_conntrack_l4proto_gre4 static |
| |
Colin King <colin.king@canonical.com> wrote: > From: Colin Ian King <colin.king@canonical.com> > > The structure nf_conntrack_l4proto_gre4 is local to the source and does > not need to be in global scope, so make it static.
This bug was added in commit b9679a9fd3a7d36ea3deb2864a00cc413c5aae28 netfilter: conntrack: l4 protocol trackers can be const
> -struct nf_conntrack_l4proto nf_conntrack_l4proto_gre4 = { > +static struct nf_conntrack_l4proto nf_conntrack_l4proto_gre4 = {
This should be 'static const'.
| |