lkml.org 
[lkml]   [2017]   [Dec]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [alsa-devel] [PATCH v4 12/15] soundwire: cdns: Add sdw_master_ops and IO transfer support
    From
    Date

    > struct sdw_cdns {
    > struct device *dev;
    > struct sdw_bus bus;
    > unsigned int instance;
    >
    > + u32 response_buf[0x80];

    last nit-pick: use a #define for the size.
    Also are you sure about the value? I vaguely recall that the FIFO was
    32-deep, you are confusing bytes and words here?

    > + struct completion tx_complete;
    > + struct sdw_defer *defer;
    > +
    > void __iomem *registers;
    >
    > bool link_up;
    > + unsigned int msg_count;
    > };
    >

    \
     
     \ /
      Last update: 2017-12-02 01:03    [W:4.059 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site