Messages in this thread | | | From | "Z.q. Hou" <> | Subject | RE: [PATCH 2/2] mtd: m25p80: restore the addressing mode when stop using the flash | Date | Fri, 1 Dec 2017 10:06:29 +0000 |
| |
Hi Cyrille,
Thanks for your comments!
> -----Original Message----- > From: Cyrille Pitchen [mailto:cyrille.pitchen@wedev4u.fr] > Sent: 2017年12月1日 16:58 > To: Z.q. Hou <zhiqiang.hou@nxp.com>; linux-mtd@lists.infradead.org; > linux-kernel@vger.kernel.org; computersforpeace@gmail.com; > dwmw2@infradead.org; boris.brezillon@free-electrons.com; > marek.vasut@gmail.com; richard@nod.at > Subject: Re: [PATCH 2/2] mtd: m25p80: restore the addressing mode when > stop using the flash > > Hi Hou, > > Le 24/11/2017 à 11:08, Zhiqiang Hou a écrit : > > From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com> > > > > Add .shutdown function to restore the addressing mode in reboot > > process, and add the same operation to the .remove function. > > > > Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com> > > --- > > drivers/mtd/devices/m25p80.c | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/drivers/mtd/devices/m25p80.c > > b/drivers/mtd/devices/m25p80.c index dbe6a1de2bb8..867bd2d5a267 > 100644 > > --- a/drivers/mtd/devices/m25p80.c > > +++ b/drivers/mtd/devices/m25p80.c > > @@ -307,10 +307,17 @@ static int m25p_remove(struct spi_device *spi) > > { > > struct m25p *flash = spi_get_drvdata(spi); > > > > + spi_nor_restore_addr_mode(&flash->spi_nor); > > maybe add a new line here. > > Otherwise, this looks good :)
Yes, will add in next version, thanks a lot for the suggestion!
Thanks, Zhiqiang
| |