lkml.org 
[lkml]   [2017]   [Nov]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86, build: Make genimage.sh little more quite
On Wed, Nov 08, 2017 at 10:01:37AM +0100, Ingo Molnar wrote:
>
> * changbin.du@intel.com <changbin.du@intel.com> wrote:
>
> > From: Changbin Du <changbin.du@intel.com>
> >
> > This change suppresses the 'dd' output and adds '-quite' parameter
> > to mkisofs tool. None of the messages matter to the user. Now:
> >
> > $ make isoimage
> > ...
> > Kernel: arch/x86/boot/bzImage is ready (#75)
> > GENIMAGE arch/x86/boot/image.iso
> > Using /usr/lib/ISOLINUX/isolinux.bin
> > Using /usr/lib/syslinux/modules/bios/ldlinux.c32
> > Kernel: arch/x86/boot/image.iso is ready
>
> Could you please also remove the other unnecessary lines as well, from the default
> build log:
>
> > Using /usr/lib/ISOLINUX/isolinux.bin
> > Using /usr/lib/syslinux/modules/bios/ldlinux.c32
> > Kernel: arch/x86/boot/image.iso is ready
>
> The build process is using a ton of files and we don't list them. Maybe print them
> when V=1, but not by default.
>
> The only lines printed should be:
>
> > Kernel: arch/x86/boot/bzImage is ready (#75)
> > GENIMAGE arch/x86/boot/image.iso
>
> Users are totally not interested in the details. They want to see a single line of
> output about which file is being built, but that's it.
>
I agree with you. So I will remove the 'Using ...', and 'set -x' if V=1.

> Thanks,
>
> Ingo

--
Thanks,
Changbin Du
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2017-11-09 07:07    [W:0.056 / U:0.468 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site