lkml.org 
[lkml]   [2017]   [Nov]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRE: [Intel-wired-lan] [PATCH] i40e: remove redundant initialization of read_size
    Date
    > From: Brown, Aaron F
    > Sent: Thursday, November 9, 2017 7:16 PM
    > To: 'Colin King' <colin.king@canonical.com>; Kirsher, Jeffrey T
    > <jeffrey.t.kirsher@intel.com>; intel-wired-lan@lists.osuosl.org;
    > netdev@vger.kernel.org
    > Cc: kernel-janitors@vger.kernel.org; linux-kernel@vger.kernel.org
    > Subject: RE: [Intel-wired-lan] [PATCH] i40e: remove redundant initialization
    > of read_size
    >
    > > From: Intel-wired-lan [mailto:intel-wired-lan-bounces@osuosl.org] On
    > Behalf
    > > Of Colin King
    > > Sent: Sunday, November 5, 2017 5:04 AM
    > > To: Kirsher, Jeffrey T <jeffrey.t.kirsher@intel.com>; intel-wired-
    > > lan@lists.osuosl.org; netdev@vger.kernel.org
    > > Cc: kernel-janitors@vger.kernel.org; linux-kernel@vger.kernel.org
    > > Subject: [Intel-wired-lan] [PATCH] i40e: remove redundant initialization of
    > > read_size
    > >
    > > From: Colin Ian King <colin.king@canonical.com>
    > >
    > > Variable read_size is initialized and this value is never read, it is
    > > instead set inside the do-loop, hence the intialization is redundant
    > > and can be removed. Cleans up clang warning:
    > >
    > > drivers/net/ethernet/intel/i40e/i40e_nvm.c:390:6: warning: Value stored
    > > to 'read_size' during its initialization is never read
    > >
    > > Signed-off-by: Colin Ian King <colin.king@canonical.com>
    >
    > s/intialization/initialization/g

    Other than that typo, looks fine:
    Tested-by: Aaron Brown <aaron.f.brown@intel.com>

    \
     
     \ /
      Last update: 2017-11-10 04:40    [W:4.093 / U:0.076 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site